Add regression test for enhanced SSL heads#100
Merged
Conversation
lukifer23
deleted the
codex/add-test-module-for-policyvaluenet-with-ssl-tasks
branch
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive regression testing for enhanced SSL (Self-Supervised Learning) heads in the PolicyValueNet model. The test validates that multiple SSL tasks work correctly, producing tensors with expected shapes and maintaining finite loss values.
- Validates SSL head outputs for piece, threat, pin, fork, and control tasks
- Tests loss computation and ensures proper tracking of task-specific statistics
- Verifies that enabling/disabling SSL tasks correctly updates the loss dictionary
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+23
to
+26
| if batch_size > len(boards): | ||
| boards.extend(boards[: batch_size - len(boards)]) | ||
|
|
||
| tensors = [board_to_tensor(b) for b in boards[:batch_size]] |
There was a problem hiding this comment.
[nitpick] The logic for extending boards when batch_size exceeds available boards could be clearer. Consider using modulo operation or explicit repetition with a comment explaining the behavior.
Suggested change
| if batch_size > len(boards): | |
| boards.extend(boards[: batch_size - len(boards)]) | |
| tensors = [board_to_tensor(b) for b in boards[:batch_size]] | |
| # Repeat boards as necessary to ensure we have at least batch_size elements | |
| import itertools | |
| boards = list(itertools.islice(itertools.cycle(boards), batch_size)) | |
| tensors = [board_to_tensor(b) for b in boards] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e41280034c832391dbf23dc5ddfcaa